fix($markdown): support path without file extension when importing code snippets #2677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where code snippets in markdown can reference a filename to include only if the filename has an extension.
For example, including a snippet like this:
(note the path does not contain a
.
) results in the snippet being rendered as the stringInvalid code snippet option
even if the target file exists.The bug is caused by an overly restrictive regex that demands at least one literal
.
in the include path. This PR fixes the regex and adds a test case.My personal preference would be to refactor the relatively large regex into simpler parsing steps, but I don't want to mess with it and inadvertently introduce subtle side effects :/
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot: N/A
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications: N/A
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: